search

greynoise-design / laravel-coding-standard

Laravel 5 Coding Standard for PHP_CodeSniffer 3
MIT License
7 stars 2 forks source link

Rulesete ignores files containing "xml" anywhere in the filename #18

Open thedavej opened 6 years ago

thedavej commented 6 years ago

https://github.com/greynoise-design/laravel-coding-standard/blob/9b1050bda51ba8dd38c795230f0ca7beb28e8b83/GreynoiseLaravel/ruleset.xml#L16

I'm not sure why, but this line causes any files or directories that contain the string "xml" in their name to be ignored. My project directory is "XML-Feed-Tool" and phpcs would ignore all of my files. I was mainly focused on a file named "XmlFeedScanner.php" which was still ignored when copied to a new directory called "testing." If I rename the file to something else, like "test.php" inside the "testing" directory, it works fine. I confirmed that commenting out this line restores functionality in my "Xml-Feed-Tool" project.

louisl commented 6 years ago

Thanks for the report, I'll take a look when I get a chance.