search

grgalex / nvshare

Practical GPU Sharing Without Memory Size Constraints
Apache License 2.0
228 stars 24 forks source link

From reviewing code not live experience: Hard coded to 10 virtual GPU's? #17

Closed jake-brewer-isa closed 8 months ago

jake-brewer-isa commented 8 months ago

It looks like there is a hard coded limit at 10 virtual GPU's.

When multi-GPU support is added, will this work well and add value to a 12 GPU machine?

kubernetes/manifests/device-plugin.yaml:64-65

- name: NVSHARE_VIRTUAL_DEVICES
          value: "10"
grgalex commented 8 months ago

NVSHARE_VIRTUAL_DEVICES represents the amount of nvshare.com/gpu devices that the device plugin advertizes to kubelet for each physical GPU that it manages.

For the time being, it only manages 1 physical GPU per node. So this value means that this GPU has 10 "slots" for containers.