grgalex / nvshare

Practical GPU Sharing Without Memory Size Constraints
Apache License 2.0
229 stars 24 forks source link

Fix potential file descriptor leak #7

Closed zhao-kun closed 1 year ago

grgalex commented 1 year ago

@zhao-kun

Good catch! Thanks for the PR!

I'll take a look when I have some time.

grgalex commented 1 year ago

@zhao-kun

The commit looks good!

I usually prefer to include Signed-off-by and Reviewed-by comments at the end of the commit.

Therefore, I suggest we change the commit message to:

client: Fix potential file descriptor leak

Signed-off-by: Kun Zhao <zhaokun.km@gmail.com>
Reviewed-by: George Alexopoulos <giorgosalexo0@gmail.com>

WDYT?

zhao-kun commented 1 year ago

Sure, I have edited the commit message in your recommendation.

grgalex commented 1 year ago

Merged!