search

gribnoysup / react-yandex-maps

Yandex Maps API bindings for React
MIT License
327 stars 114 forks source link

deps: move to mini-create-react-context #305

Open amankkg opened 3 years ago

amankkg commented 3 years ago

Fixes #301

While peer deps were updated in #273, it was not enough actually since create-react-context peerDeps range is not updated. Now it should allow clear installation of React 17

Change is similar to ReactTraining/react-router#6692 so I believe mini-create-react-context is a drop-in replacement for an old library

I was unable to launch neither project itself or docz locally to test it, but my working project with updated bundles of react-yandex-maps worked well (e.g. YMap, YMaps components)

happylolonly commented 3 years ago

When will you merge? Not working with react 17.0.2 now @mmarkelov @gribnoysup possible to merge it?

mmarkelov commented 3 years ago

@happylolonly unfortunately i can't merge, because i don't have permissions

swayok commented 2 years ago

@mmarkelov how about merging? It was approved several months ago...

mmarkelov commented 2 years ago

@mmarkelov how about merging? It was approved several months ago...

I don't have permission to merge

swayok commented 2 years ago

@mmarkelov can you notify those who can merge?

gribnoysup commented 2 years ago

@swayok I get notifications and will look at PRs in detail when I have time.

You're free to fork this code at any moment and republish under a different name or in your private registry, or use a tool like patch-package if you want to address any issues in your application immediately and can't wait