Improve German translations

grid-js / gridjs

Advanced table plugin

https://gridjs.io

MIT License

4.39k stars 240 forks source link

Improve German translations #1416

Closed GitRon closed 7 months ago

GitRon commented 8 months ago

Describe the bug The German translation is a little clunky and wrong at some points.

To Reproduce Turn on German translation as a native speaker.

Expected behavior Proper German 🙃

I'll provide a PR in a second.

Best regards
Ronny

rubycon commented 8 months ago

I agree, the issue comes from how translation is handled and not the translations themselves :

https://github.com/grid-js/gridjs/blob/master/l10n/de_DE.ts

The translation is done on an word basis (showing, of, to, results...) instead of sentences, which is usually how its done in most project.

GitRon commented 8 months ago

Hi @rubycon! Thx! Nevertheless, I'd be happy to get the translation update in ASAP since I want to use it in a German webapp 🙂 The other thing should be handled in a separate ticket - since we'd have to update all other translation files as well.

GitRon commented 7 months ago

@daniel-werner I saw you in the contributor list and I guess you are German-speaking by your name? Could you give an estimate when my small PR might be reviewed?

Thx and sorry for being pushy!
Ronny

daniel-werner commented 7 months ago

Hey @GitRon, hehe only my name is German, but unfortunately my german language is on quite low level. However the PR looks good to me, but only a maintainer can approve or merge it. Maybe @afshinm could help.

christoph-teichmeister commented 7 months ago

Just bumped into this myself. +1 on this!

GitRon commented 7 months ago

Awesome, thx @afshinm!