search

grid-parity-exchange / Egret

Tools for building power systems optimization problems
Other
129 stars 51 forks source link

Degrees vs Radians inconsistency... #213

Open carldlaird opened 3 years ago

carldlaird commented 3 years ago

It looks like we read in "degrees" for voltage angles from the matpower based input files. However, our Pyomo models are in radians. When they put the data back into the model data object (following a solve), it looks like they are not being converted back to degrees.

bknueven commented 3 years ago

My suggestion (putting it here for posterity) is to add this to (and perhaps refactor/move) the scale/unscale capability. It probably should be its own module, at minimum. https://github.com/grid-parity-exchange/Egret/blob/13d759a3a43be1522b8fb3c9c18035b1bf785efc/egret/model_library/transmission/tx_utils.py#L209-L482

jeanpaulwatson commented 3 years ago

This is definitely a broad issue. For example, when we write incumbent-finders or fixing schemes that are problem-specific, e.g., for unit commitment, we're working typically working directly on Egret models. I'm with Ben in that the we need a general scale/unscale module, to include angles, the stuff Ben mentions above, and anything per-unit related.