After #263 I realized the list of ancillary services was really in two place. This standardizes it to egret/model_library/transmission/tx_utils.py, which already knows a lot about the underlying model data structure. Along the way I noticed that supplemental_reserve breaks the *_requirement/*_price/*_shortfall pattern, so this changes the name of supplemental_price and supplemental_shortfall to match that pattern.
Changes proposed in this PR:
Centralize list of ancillary services to tx_utils
Rename supplemental_price to supplemental_reserve_price and supplemental_shortfall to supplemental_reserve_shortfall (including json files).
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:
I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
Fixes N/A
Summary/Motivation:
After #263 I realized the list of ancillary services was really in two place. This standardizes it to
egret/model_library/transmission/tx_utils.py, which already knows a lot about the underlying model data structure. Along the way I noticed thatsupplemental_reservebreaks the*_requirement/*_price/*_shortfallpattern, so this changes the name ofsupplemental_priceandsupplemental_shortfallto match that pattern.Changes proposed in this PR:
supplemental_pricetosupplemental_reserve_priceandsupplemental_shortfalltosupplemental_reserve_shortfall(including json files).Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: