Simplify logger implementation

grid-x / modbus

BSD 3-Clause "New" or "Revised" License

78 stars 26 forks source link

Simplify logger implementation #71

Closed andig closed 1 year ago

andig commented 1 year ago

Follow-up to https://github.com/grid-x/modbus/pull/31.

This PR removes the additional Logger fields. They should not be necessary- it seems that the serial port's logger actually is accessible externally. This is also non-breaking since the private field's hierarchy is not visible.

andig commented 1 year ago

Ping for review

andig commented 1 year ago

@guelfey @gq0 any chance for merging?

andig commented 1 year ago

@guelfey @gq0 any chance for merging?