grid-x / modbus

BSD 3-Clause "New" or "Revised" License
76 stars 25 forks source link

Enhancement of Logging System in Modbus Package #79

Closed ValentinMontmirail closed 3 months ago

ValentinMontmirail commented 7 months ago

Description

The current implementation of the loggerinterface in our Modbus package exclusively uses the Printfmethod for logging. This approach inherently treats all logs as INFOlevel, which is not always appropriate. Many of these logs are more suited to a DEBUGlevel, particularly given their nature and the detail they provide.

Problem

The primary issue with the current logging system is the lack of granularity. Without distinct log levels (such as DEBUG, INFO, ERROR), it becomes challenging to filter logs based on their severity or importance. This limitation hinders effective debugging and monitoring, especially in production environments where log verbosity needs to be controlled.

Proposed Solution:

andig commented 3 months ago

Please note https://github.com/grid-x/modbus/pull/80#issuecomment-2090385778. I'd strongly suggest to revert #80.