search

grid-x / modbus

BSD 3-Clause "New" or "Revised" License
82 stars 28 forks source link

Return data of too large responses #81

Closed srebhan closed 6 months ago

srebhan commented 9 months ago

Some devices send too much data in read responses which is not a grey-zone of the spec. However, as we do have enough bytes to return, this PR does so as proposed in the discussion . To be able to detect those malformed responses, the PR also introduces a custom error users can check against.

resolves #52

srebhan commented 8 months ago

@hsteidl anything I can do to get this merged?

srebhan commented 8 months ago

@gq0 or @tretmar is there anything I can do to get this PR going forward?

dammarco commented 8 months ago

Hello @srebhan , we are currently not able to take the time and assess the changes here thoroughly. It's still not forgotten though ;) We just need time to think about it as this might have direct impact on our product in the end.

srebhan commented 7 months ago

Any update here? We need this to fix an actual long-standing issue in Telegraf (https://github.com/influxdata/telegraf/issues/11099) and the effect for existing code is zero if you did proper error checking before...

srebhan commented 6 months ago

@hsteidl or @tretmar any update? Another month passed by... This change is fully backward compatible and will NOT change the current behavior if you did error checking before...

andig commented 6 months ago

@srebhan do you want to re-open against https://github.com/evcc-io/modbus? Seems we'll need to go for a permanent fork anyway due to lack of feedback on https://github.com/grid-x/modbus/pull/70.

dammarco commented 6 months ago

@srebhan there is a still a conflict that has to be addressed within client.go. Could you have a look and ping me afterwards again? 😊

srebhan commented 6 months ago

@tretmar resolved the confliict...

Thanks for moving this forward. Hope to see some maintenance for this library in the future as it is a quite nice one...

dammarco commented 6 months ago

Thanks @srebhan . I'm working on it to get the team more active in here ;)

srebhan commented 6 months ago

@tretmar is there any plan for doing a release anytime soon? Otherwise I will pin to the git commit in Telegraf...

dammarco commented 6 months ago

you mean something like that: https://github.com/grid-x/modbus/releases/tag/v1.1? 🤔 We can do that if it helps you ;)

hnicolaysen commented 5 months ago

Hi @srebhan, we currently don't have a proper release strategy for this repository. I just opened a discussion regarding this, please have a look at #89. 🙂