search

grid-x / modbus

BSD 3-Clause "New" or "Revised" License
78 stars 26 forks source link

Return to minimal logger interface #88

Closed andig closed 4 months ago

andig commented 4 months ago

Fix https://github.com/grid-x/modbus/issues/87. Replaces https://github.com/grid-x/modbus/pull/86. Refs https://github.com/grid-x/modbus/pull/80#issuecomment-2092654024.

Re-exposes

Printf(format string, v ...any)

as minimal logger interface, this time as public type.

Please squash before committing.

/cc @tretmar @srebhan

andig commented 4 months ago

Please squash before committing.

@tretmar didn't work. Makes for ugly commit history and potentially harder to merge in forks.

dammarco commented 4 months ago

@andig Just to understand you here... you want to have 1 commit per merged PR in the end?

andig commented 4 months ago

I think that would be great. At least when the PR does not contain an intentional logical breakdown of the changes.

dammarco commented 4 months ago

Okay, we're working internally with a different approach - so that's why we don't squash before merging... simply because we are used to a different approach ;) We follow the approach that the authors of PRs are responsible to have a clean commit structure, including squashing. Still, in a public repository like this here, it might not be the best approach as we can't force everyone to follow this clean commit approach 🤔

srebhan commented 4 months ago

@tretmar well you can force people, but why if you can just squash the commits automatically? :-) We are doing this in Telegraf and you can configure Github to do so.

The big advantage of squashing IMO is that you do have a cleaner commit history keeping things together, but that's a matter of taste of course...