search

gridaco / code

Design to Code Engine
https://grida.co/code
Apache License 2.0
225 stars 30 forks source link

Support empty `target.fills` when resolving image hashes #195

Closed junhoyeo closed 1 year ago

junhoyeo commented 1 year ago
  1. Since target is ReflectSceneNode, target.fills can be empty, which can sometimes lead to crash.
  2. Also, we're using multiple .filter(...)/.map(...) chains. This can be combined into .flatMap(...).
  3. This PR also changes type of images to match parameter typings for service.fetch(...): (string | null)[] -> string[]
Screenshot 2022-12-04 at 11 10 31 PM
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
code ✅ Ready (Inspect) Visit Preview Dec 4, 2022 at 3:14PM (UTC)
softmarshmallow commented 1 year ago

👍 Good points