search

gridap / Gridap.jl

Grid-based approximation of partial differential equations in Julia
MIT License
695 stars 95 forks source link

General polytope implementation #1006

Closed pmartorell closed 4 months ago

pmartorell commented 4 months ago

@santiagobadia

This PR includes the implementation of general polytopes in Gridap.

These polytopes are named GeneralPolytope<:Polyhedron. Here, Polygon and Polyhedron are aliases of GeneralPolytope in 2 and 3 dimensions, respectively.

We note, that this implementation has been migrated from STLCutters.jl, see also https://github.com/gridap/STLCutters.jl/pull/33

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 93.24324% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 88.26%. Comparing base (34faf27) to head (8b70346).

Files Patch % Lines
src/ReferenceFEs/GeneralPolytopes.jl 93.24% 25 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1006 +/- ## ========================================== + Coverage 88.18% 88.26% +0.08% ========================================== Files 176 177 +1 Lines 22055 22425 +370 ========================================== + Hits 19449 19794 +345 - Misses 2606 2631 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

santiagobadia commented 4 months ago

@pmartorell can you replace GraphPolytope by GeneralPolytope?

pmartorell commented 4 months ago

@santiagobadia I have changed the name