gridap / Gridap.jl

Grid-based approximation of partial differential equations in Julia
MIT License
708 stars 97 forks source link

Bug in Forward Diff of VectorValue #240

Closed santiagobadia closed 4 years ago

santiagobadia commented 4 years ago

@fverdugo I think we have a typo in the forward diff of diff operators when the field is not a scalar.

I have created a test in this branch that crashes

https://github.com/gridap/Gridap.jl/blob/bug-forward-diff/test/GridapTests/VectorPoisson.jl

fverdugo commented 4 years ago

I'll take a look!

In any case, it is strange since autodiff for vector-valued PDEs is been tested in these two tests also with 2nd order manufatured solutions.

https://github.com/gridap/Gridap.jl/blob/master/test/GridapTests/PoissonTests.jl

https://github.com/gridap/Gridap.jl/blob/master/test/GridapTests/StokesTaylorHoodTests.jl

fverdugo commented 4 years ago

your diver passed in my environment:

$ git checkout bug-forward-diff
$ julia --project=.
pkg> instantiate
julia> include("test/GridapTests/VectorPoisson.jl")
[ Info: Precompiling Gridap [56d4f2e9-7ea1-5844-9cf6-b9c51ca7ce8e]
Test Passed

Can you provide this info?

julia> versioninfo()
Julia Version 1.4.0
Commit b8e9a9ecc6 (2020-03-21 16:36 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)
Environment:
  JULIAROOT = /home/fverdugo/Apps/julia/julia-1.4.0

(Gridap) pkg> status ForwardDiff
Project Gridap v0.9.1
Status `~/Code/jl/Gridap.jl/Project.toml`
  [f6369f11] ForwardDiff v0.10.10
fverdugo commented 4 years ago

In addition, try to run these tests (they pass in my machine and in Travis):

julia> include("test/GridapTests/PoissonTests.jl")
Main.PoissonTests

julia> include("test/GridapTests/StokesTaylorHoodTests.jl")
Main.StokesTaylorHoodTests

julia> include("test/FieldsTests/DiffOperatorsTests.jl")
Main.DiffOperatorsTests

If they fail in your machine, it should be something environment-related not Gridap-related. Perhaps we are using different versions of some dependency.

santiagobadia commented 4 years ago

I have updated and now seems to work