search

gridap / Gridap.jl

Grid-based approximation of partial differential equations in Julia
MIT License
695 stars 95 forks source link

Generalize how the infinite norm is computed in non-linear solvers #940

Closed JordiManyer closed 1 year ago

JordiManyer commented 1 year ago

Algebra._check_convergence was using a self-implemented version of the infinite norm. This only worked for serial vectors. I've generalized the approach to use the Base.maximum(abs,v) method, which should be valid (and optimized) for each possible implementation of AbstractVector. Notably, this now works for PVector.

codecov-commenter commented 1 year ago

Codecov Report

Merging #940 (6f7d8e3) into master (578f5b7) will decrease coverage by 0.01%. Report is 4 commits behind head on master. The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
- Coverage   88.43%   88.42%   -0.01%     
==========================================
  Files         174      174              
  Lines       20627    20621       -6     
==========================================
- Hits        18241    18235       -6     
  Misses       2386     2386
Files Changed Coverage Δ
src/Adaptivity/AdaptedTriangulations.jl 77.36% <100.00%> (ø)
src/Algebra/NLSolvers.jl 98.85% <100.00%> (-0.08%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more