gridap / GridapDistributed.jl

Parallel distributed-memory version of Gridap
MIT License
103 stars 15 forks source link

Reverting DistributedGridapType #117

Closed JordiManyer closed 1 year ago

JordiManyer commented 1 year ago

In PR #98 we introduced a new base type for distributed objects, called DistributedGridapType. After some consideration, we have decided to revert the change. It introduces inconsistencies ans limitations we would like to avoid.

amartinhuertas commented 1 year ago

@JordiManyer ... tests are failing. I think you still have the include of the file you eliminated

JordiManyer commented 1 year ago

@JordiManyer ... tests are failing. I think you still have the include of the file you eliminated

I've pushed the change (it appears in the network tree view) but somehow does not appear here....

amartinhuertas commented 1 year ago

@JordiManyer ... can you please edit the NEWS.md file to reflect the change? Thanks!

codecov-commenter commented 1 year ago

Codecov Report

Merging #117 (4435a28) into master (424b76c) will not change coverage. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@          Coverage Diff           @@
##           master    #117   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          11      10    -1     
  Lines        1694    1694           
======================================
  Misses       1694    1694           
Impacted Files Coverage Δ
src/Algebra.jl 0.00% <0.00%> (ø)
src/CellData.jl 0.00% <ø> (ø)
src/FESpaces.jl 0.00% <ø> (ø)
src/Geometry.jl 0.00% <ø> (ø)
src/MultiField.jl 0.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more