Closed JordiManyer closed 1 year ago
Merging #128 (f73f0d6) into block-assemblers-v0.3 (25ece1f) will not change coverage. The diff coverage is
0.00%
.:exclamation: Current head f73f0d6 differs from pull request most recent head c8c6d2a. Consider uploading reports for the commit c8c6d2a to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## block-assemblers-v0.3 #128 +/- ##
======================================================
Coverage 0.00% 0.00%
======================================================
Files 11 12 +1
Lines 2242 2402 +160
======================================================
- Misses 2242 2402 +160
Files Changed | Coverage Δ | |
---|---|---|
src/Algebra.jl | 0.00% <0.00%> (ø) |
|
src/BlockPartitionedArrays.jl | 0.00% <0.00%> (ø) |
|
src/FESpaces.jl | 0.00% <0.00%> (ø) |
|
src/MultiField.jl | 0.00% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Tests will not fail after the release of Gridap v0.17.20
Todo/Done:
consistent_local_views
andchange_ghost
. Expand functionality ofchange_ghost
.OwnAndGhostVector
as vector partition of resultingPVector
s, as a way to reduce memory copying when transferring between FESpace and linear system layouts.BlockPArray <: AbstractBlockArray
, a new type that behaves as aBlockArray{PArray}
and which fulfills the APIs of bothPArray
andAbstractBlockArray
. This will get rid of the type piracy we have been using up to now and gets rid of some of the issues we are having (mainly, the fact thatBlockArray
expects its blocks to be indexable).MultiFieldFESpace{<:BlockMultiFieldStyle}
now has aBlockPRange
as gids, which makes the fespace dof vector be of typeBlockPVector
. This is necessary to create consistency between fespace and system vectors, which in turn avoids memory allocations/copies when transferring between FESpace and linear system layouts.To Think:
BlockPArray
constructors work withBlockPRange
s, which is inconsistent with PartitionedArrays. Should we be trying to be coherent? How can we do it well for dispatching?Left for another PR:
PRange
ghost-related optimisations while assembling the system matrix. This will create linear systems which ghost layout is compatible with the original FESpace, avoiding copying data when transferring between FESpace and linear system layouts.