search

gridap / GridapDistributed.jl

Parallel distributed-memory version of Gridap
MIT License
103 stars 15 forks source link

PLaplacianTests fail with Julia 1.7.3 #129

Open principejavier opened 1 year ago

principejavier commented 1 year ago

The error is ERROR: Scalar indexing on DebugArray is not allowed for performance reasons. and it occurs at this line

With Julia 1.9.3 it runs sucessfully

The reason for this behavior is the change in the implementation of copy!(dst::AbstractVector, src::AbstractVector) which indexed dst directly in v1.7.3, see here, whereas it calls copyto! in v1.9.3, see here

Possible solutions I see:

  1. increase compat
  2. implement copy! for DebugArray and MPIArray in PartitionedArrays.jl
  3. eliminate this overload which is not required after the this commit to PartitionedArrays.jl (although the test will fail with previous releases). I verified that copy(a::PSparseMatrix) and copy!(b::PSparseMatrix,a::PSparseMatrix) work with latest PartitonedArrays.jl.

@fverdugo , @amartinhuertas , @JordiManyer any thoughts?