gridap / GridapDistributed.jl

Parallel distributed-memory version of Gridap
MIT License
103 stars 15 forks source link

Bugfix: TransientFESpaces broken for Gridap#master #135

Closed JordiManyer closed 11 months ago

JordiManyer commented 11 months ago

The test StokesOpenBoundaryTests.jl breaks on Gridap#master.

After investigating a little, this seems to come from this recent PR, where we added block assembly to TransientMultiFieldFESpaces. In doing so, we made the type quite a lot more complex. This requires more FESpace API methods to be implemented by DistributedFESpace.

I think all tests are good now.

@amartinhuertas @oriolcg @tamaratambyah

codecov-commenter commented 11 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (50184f2) 0.00% compared to head (0c9e891) 0.00%.

Files Patch % Lines
src/FESpaces.jl 0.00% 6 Missing :warning:
src/TransientDistributedCellField.jl 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #135 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 12 12 Lines 2448 2458 +10 ====================================== - Misses 2448 2458 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.