search

gridap / GridapEmbedded.jl

Embedded finite element methods in Julia
Other
42 stars 14 forks source link

Support for distributed discrete geometries #90

Closed zjwegert closed 1 week ago

zjwegert commented 5 months ago

Issue #88 and #89

zjwegert commented 5 months ago

I think this is ready for a look over. Let me know if anything needs to be adjusted.

ericneiva commented 1 month ago

Hi, @zjwegert, I have some time to look into this before the end of the week. Do you need to update anything before the merge?

zjwegert commented 1 month ago

Hi @ericneiva, I think this is ready to be looked at.

@JordiManyer were there any other changes to incorporate from our recent work?

JordiManyer commented 1 month ago

I don't think this can be merged. We've been doing quite a lot of changes to accommodate autodiff, and some of the stuff here is no longer needed. I would leave this open for now, with the understanding we'll update changes here when we are done testing things out.

zjwegert commented 1 month ago

I agree, let’s do that!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Jordi Manyer Fuertes @.> Sent: Thursday, October 10, 2024 8:57:25 AM To: gridap/GridapEmbedded.jl @.> Cc: Zach Wegert @.>; Mention @.> Subject: Re: [gridap/GridapEmbedded.jl] Support for distributed discrete geometries (PR #90)

I don't think this can be merged. We've been doing quite a lot of changes to accommodate autodiff, and some of the stuff here is no longer needed. I would leave this open for now, with the understanding we'll update changes here when we are done testing things out.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/gridap/GridapEmbedded.jl/pull/90*issuecomment-2403565054__;Iw!!NVzLfOphnbDXSw!GZHjNuR8nXgZtmvPbKVCW7UtmOR39Px5VxAovjaYQ5gNDKxGVL-1MtH1NllJkskgSv0VUrXIO39GUt6263QV6n_Ng_dPf5cflw$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOOWL4PMJ66BJAQ7U7TDO6TZ2WYFLAVCNFSM6AAAAABI6EVSJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGU3DKMBVGQ__;!!NVzLfOphnbDXSw!GZHjNuR8nXgZtmvPbKVCW7UtmOR39Px5VxAovjaYQ5gNDKxGVL-1MtH1NllJkskgSv0VUrXIO39GUt6263QV6n_Ng_dN8Ox7Rw$. You are receiving this because you were mentioned.Message ID: @.***>

ericneiva commented 1 month ago

Okay, perfect, @zjwegert and @JordiManyer, thanks for the heads up!

JordiManyer commented 1 week ago

We will be merging this into a new branch and continuing the work from there.