gridap / GridapMakie.jl

Makie plotting recipes for Gridap
MIT License
34 stars 8 forks source link

update to current Makie version #56

Closed JonasIsensee closed 2 years ago

JonasIsensee commented 2 years ago

This PR updates the version bounds and adds the missing definition to enable compatibility to the latest Makie release.

this supersedes all the other compat PRs

closes #38 #44 #46 #47 #48 #49 #53 #54 #55

codecov-commenter commented 2 years ago

Codecov Report

Merging #56 (7b0be96) into master (0e9bcf6) will increase coverage by 0.06%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   93.06%   93.13%   +0.06%     
==========================================
  Files           2        2              
  Lines         202      204       +2     
==========================================
+ Hits          188      190       +2     
  Misses         14       14              
Impacted Files Coverage Δ
src/conversions.jl 92.12% <ø> (ø)
src/recipes.jl 94.80% <ø> (+0.13%) :arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

fverdugo commented 2 years ago

Thanks for this @JonasIsensee