search

gridap / GridapMakie.jl

Makie plotting recipes for Gridap
MIT License
34 stars 8 forks source link

GridapMakie is no longer compatible with Makie 0.15 (and provably 0.13) #62

Closed fverdugo closed 6 days ago

fverdugo commented 1 year ago

We need to change the compat section accordingly.

hammy4815 commented 7 months ago

Hi @fverdugo , I've been able to locally remove the compat section (M1 chip), update all dependencies, and use the recipes without any issues. 

  [5789e2e9] FileIO v1.16.2
  [1a297f60] FillArrays v1.9.3
  [e9467ef8] GLMakie v0.9.6
  [5c1252a2] GeometryBasics v0.4.10
  [56d4f2e9] Gridap v0.17.23
  [ee78f7c6] Makie v0.20.5

Are there any issues that I overlooked? Otherwise, could we bump?

hammy4815 commented 7 months ago

Hi @fverdugo ,

I've updated again to the most recent dependencies:

  [5789e2e9] FileIO v1.16.2
  [1a297f60] FillArrays v1.9.3
  [e9467ef8] GLMakie v0.9.8
  [5c1252a2] GeometryBasics v0.4.10
  [56d4f2e9] Gridap v0.17.23
  [ee78f7c6] Makie v0.20.7

And I still seem to be able to build plots using the recipes without encountering any problems.

fverdugo commented 7 months ago

Hi @hammy4815,

thanks for reporting.

can you modify the compat section (link below) with the new version numbers and then open a PR?

https://github.com/gridap/GridapMakie.jl/blob/26399574aa6d5eb4c48c9e8079c04d02e9daf56a/Project.toml#L15

hammy4815 commented 7 months ago

Sure, no problem @fverdugo . I just opened a PR.

JordiManyer commented 6 days ago

Closed by PR #73