search

gridap / GridapMakie.jl

Makie plotting recipes for Gridap
MIT License
34 stars 8 forks source link

GridapMakie seems outdated #70

Closed eschnett closed 6 days ago

eschnett commented 6 months ago

GridapMakie's Project.toml declarations refer to quite old version of some packages (e.g. FillArrays, Makie, CairoMakie). In addition, trying to use it results in an error:

julia> using GridapMakie
Precompiling GridapMakie
        Info Given GridapMakie was explicitly requested, output will be shown live
ERROR: LoadError: UndefVarError: `point_iterator` not defined

(This is with Julia 1.10.)

rveltz commented 3 weeks ago

Hi,

I have tried to solve it myself but did not succeed. Can you please resurrect this very useful package?

JordiManyer commented 1 week ago

@ovanvincq has a branch going on with some nice-looking changes. Is it functional? If so, I'm happy to accept a PR and merge the changes for everyone.

JordiManyer commented 6 days ago

Actually I'm blind, there is a PR already, see #73

JordiManyer commented 6 days ago

The PR has been merged, and it seems like the tests pass. I'll do the next release some day next week (once we fix the small issue we are having with the documenter keys).