search

gridap / GridapMakie.jl

Makie plotting recipes for Gridap
MIT License
34 stars 8 forks source link

Compatibility with Makie 0.21 #73

Closed ovanvincq closed 6 days ago

ovanvincq commented 2 months ago

I made some modifications to make GridapMakie compatible with Makie 0.21 (but not with previous versions).

There is only one small drawback: I do not understand how to change axis type for a full recipe and one must specify axis=(type=Makie.Axis3,aspect=:data) when plotting 3D data.

JordiManyer commented 6 days ago

Hi @ovanvincq , thank you for your contribution! Sorry it took so long to get a response, I was not aware of the PR...

Could you please pull the master branch to resolve the issues? Most of the changes you already apply, so I believe it will be quite straightforward.

JordiManyer commented 6 days ago

There is only one small drawback: I do not understand how to change axis type for a full recipe and one must specify axis=(type=Makie.Axis3,aspect=:data) when plotting 3D data.

I am definitely not an expert, but browsing through the docs I found this: 

Makie.preferred_axis_type(plot::MyPlot) = Makie.LScene # if you need the entire plot object as information

and from the Axis3 docs, I think we might be able to give it the aspect kwarg as

Axis3(aspect = :data)

could you try it out @ovanvincq ?

ovanvincq commented 6 days ago

I am definitely not an expert, but browsing through the docs I found this:

Makie.preferred_axis_type(plot::MyPlot) = Makie.LScene # if you need the entire plot object as information

@JordiManyer Wonderful! I I commit the changes to take your advice into account and it seems that all the examples (in runtest.jl and README.md) work.

JordiManyer commented 6 days ago

Ok great! I've resolved the conflicts with master. Once the test pass I'll merge. Thank you again for your time and work!