amartinhuertas commented 2 years ago

@fverdugo ... I found a BUG in plaplacian tests.

I have reproduced the BUG in this PR, so that we can keep track of it, but it is not yet solved (draft PR).

Do have an idea of what might be happening? (Hard to tell, I know).

amartinhuertas commented 2 years ago

Do have an idea of what might be happening? (Hard to tell, I know).

Ok, false alarm. The bug disappears with https://github.com/gridap/GridapPETSc.jl/pull/75

I guess this is the very same bug that impacted you, right? Now I understand why you say "this PR might be important for you"

This PR can be accepted after revision.

codecov-commenter commented 2 years ago

Codecov Report

Merging #80 (bb0b822) into master (7196743) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files           9        9           
  Lines         831      831           
=======================================
  Hits          737      737           
  Misses         94       94

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7196743...bb0b822. Read the comment docs.

gridap / GridapPETSc.jl

Bug in plaplacian tests #80

Codecov Report