search

gridap / MiniQhull.jl

A small Julia wrapper of the Qhull library
Other
29 stars 9 forks source link

Allow passing arbitrary flags to Qhull #11

Closed eschnett closed 3 years ago

codecov-io commented 3 years ago

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files           3        3           
  Lines          40       40           
=======================================
  Hits           37       37           
  Misses          3        3
Impacted Files Coverage Δ
src/bindings.jl 100.00% <ø> (ø)
src/MiniQhull.jl 100.00% <100.00%> (ø)
src/load.jl 76.92% <0.00%> (-1.65%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56a212b...e2ff4e6. Read the comment docs.

eschnett commented 3 years ago

I added tests, including one for a GenericString instead of a String:

help?> Test.GenericString
  The GenericString can be used to test generic string APIs that program to
  the AbstractString interface, in order to ensure that functions can work
  with string types besides the standard String type.
fverdugo commented 3 years ago

@eschnett thanks for your changes!