search

gridapapps / GridapGeosciences.jl

Gridap drivers for geoscience applications
MIT License
35 stars 3 forks source link

Tswe exp #23

Closed davelee2804 closed 3 years ago

davelee2804 commented 3 years ago

I have added an explicit solver for the thermal shallow water equations, as well as a default test configuration with a constant buoyancy (of value g) for which the thermal shallow water equations default to the regular shallow water equations. Under these conditions the solver replicates the results of the Galewsky test case, with the buoyancy staying constant vort_day6_g buoy_day6_g ener_cons mass_cons vort_cons

I then modified the initial condition so that the initial perturbation is all in the depth field, so that the initial buoyancy deviates from the constant state. The resulting buoyancy perturbation is advected with the flow field, generating high frequency oscillations vort_day6_b buoy_day6_b

codecov-commenter commented 3 years ago

Codecov Report

Merging #23 (3552608) into master (88df7d8) will decrease coverage by 8.82%. The diff coverage is 19.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   67.66%   58.83%   -8.83%     
==========================================
  Files          16       17       +1     
  Lines         801      911     +110     
==========================================
- Hits          542      536       -6     
- Misses        259      375     +116
Impacted Files Coverage Δ
src/GridapGeosciences.jl 100.00% <ø> (ø)
src/Helpers.jl 88.46% <0.00%> (-3.54%) :arrow_down:
src/ThermalShallowWaterExplicit.jl 0.00% <0.00%> (ø)
src/DiagnosticTools.jl 52.17% <46.66%> (-6.16%) :arrow_down:
src/ShallowWaterExplicit.jl 97.29% <100.00%> (+0.07%) :arrow_up:
src/ShallowWaterIMEX.jl 97.84% <100.00%> (-0.18%) :arrow_down:
src/ShallowWaterRosenbrock.jl 91.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88df7d8...3552608. Read the comment docs.