Closed davelee2804 closed 2 years ago
Thanks for your work @davelee2804 ! I have accepted the PR. The only thing I am a little bit concerned is that it seems we are somehow repeating a bunch of code when introducing new variants of the equations/solvers. I am concerned that we could end up with an explosion of code replication. Perhaps there is a way to factor further the code into common functionality. Let us think a little bit about this in the meantime.
Thanks @amartinhuertas , You make a good point. I requested this PR as without upwinding of either the facet integrals or the basis functions this was the only formulation in which I could effectively upwind the buoyancy. Once we have a better method of upwinding implemented maybe we can consolidate as you suggest....
This involves the following changes:
In the next PR the upwinded trial funcs will be added, which will allow for additional high order energy consistent stabilisation of the potential vorticty and buoyancy fields.