gridcf / UberFTP

Interactive GridFTP client
Other
2 stars 2 forks source link

Cleanup parsing of RFC2428 format responses #12

Closed msalle closed 3 years ago

msalle commented 4 years ago

Several improvements and fixes in the RFC2428 format parsing code. Among others prevent parsing the input string beyond the end (which caused several potential SEGV). Also add comments and cleanup the code structure for readability.

Fixes https://github.com/gridcf/UberFTP/issues/11

msalle commented 3 years ago

Hi @fscheiner just to check: did you manage to runtime test my patches? That would still be good...

fscheiner commented 3 years ago

No, not before merging it, I relied on your "testing" in gdb. But I will test the resulting uberftp with my IPv6 enabled GridFTP service.

fscheiner commented 3 years ago

@msalle Some results from testing uberftp with the patch from this PR: