search

gridcf / gct

Grid Community Toolkit
Apache License 2.0
46 stars 30 forks source link

first try to migrate myproxy-oauth code to python3 #200

Closed msalle closed 1 year ago

msalle commented 1 year ago

Mostly automatic changes using 2to3. Updated RH package names in README.md

fscheiner commented 1 year ago

@msalle Cool, exactly what I had hoped for.

Is there anybody that could confirm that the modified code still works as intended (because there's nothing done for "myproxy-oauth" in the "build/test" step)? Jim (@jbasney), maybe?

When merged, RPM builds on CentOS 7 will stop working, because there the respective Python 3 libs are missing AFAICS. Well, we don't actually build RPMs via the CIs and there's also no "myproxy-oauth" package in EPEL/Fedora, too - so maybe not important.

SRPM builds should work, because they're done with --nodeps, but the installation of prerequsites will fail depending on what packages we intend to install, unless we ignore the CentOS 7 case. As I understand it now, those prerequisite installations are just needed for RPM building, so we could change them as we like, building will just not work everywhere, but that is already the case for *8 and upwards w/o this PR merged.

So should we wait with the merge of this PR until we switch to *8 as main build target?

jbasney commented 1 year ago

This Python myproxy-oauth package is Globus GCSv4 code. It is deprecated. I expect that it does not work with Globus anymore. I think it should be purged from the GCT repository. Everyone should be migrated to GCSv5 by now: https://docs.globus.org/globus-connect-server/migrating-to-v5.4/

msalle commented 1 year ago

This Python myproxy-oauth package is Globus GCSv4 code. It is deprecated. I expect that it does not work with Globus anymore. I think it should be purged from the GCT repository. Everyone should be migrated to GCSv5 by now: https://docs.globus.org/globus-connect-server/migrating-to-v5.4/

Ok, wasn't sure, but in that case, I agree we should remove it. If people like they can always find back the code.

msalle commented 1 year ago

Closing this merge request since we're going to drop the code in any case.