gridcf / gct

Grid Community Toolkit
Apache License 2.0
46 stars 30 forks source link

Unknown/unsupported OpenSSL version ("30100040 (OpenSSL 3.1.4 24 Oct 2023)") #219

Open ickc opened 9 months ago

ickc commented 9 months ago

When installing on Arch Linux,

checking OpenSSL library version... configure: error: Unknown/unsupported OpenSSL version ("30100040 (OpenSSL 3.1.4 24 Oct 2023)")

From https://github.com/gridcf/gct/blob/07008c37abe56bafba82fe052b0f2cd11358ee88/gsi_openssh/source/configure.ac#L2844-L2862

C.f. https://aur.archlinux.org/packages/gct#comment-943688

fscheiner commented 9 months ago

Thanks for the pointer.

But I wonder why it doesn't work for your OpenSSL version 3.1.4. Because considering that https://github.com/openssh/openssh-portable/commit/f6d3ed9a8a9280cbb68d6a499850cfe810e92bd0 enables version 3.2.x and https://github.com/openssh/openssh-portable/commit/3e21d58a09894acb38dc69ed615d101131f473d0 enables 3.3.x, 301 should enable 3.1.x if I'm not mistaken.

And 301* should at least match the first part of 30100040 (OpenSSL 3.1.4 24 Oct 2023).

msalle commented 9 months ago

but the commit adds just the 300 and 301 as unsupported versions. Also the one before, from 2 years ago, adds 300 as unsupported version. That's different from this commit in the upstream patches.

fscheiner commented 9 months ago

@msalle

but the commit adds just the 300 and 301 as unsupported versions. Also the one before, from 2 years ago, adds 300 as unsupported version.

No, I think there is no fall-through to the unsupported *) case. If there was, all cases would fall-through instead of ending at the ;;.

msalle commented 9 months ago

ah right indeed, sorry shouldn't have looked on my phone.

The problem is that the configure.ac in gct-6.2.1653033972/gsi_openssh/source is an old one. I just noticed that the configure and configure.ac in there only support up to 3.0.X. Also the current draft release still points to that version of Jun 8, 2022. The 301 support dates back to Feb 21 (see https://github.com/gridcf/gct/commit/f60262da4d171415c8482cdaeec4025a61ce8cab)

fscheiner commented 9 months ago

ah right indeed, sorry shouldn't have looked on my phone.

I made the same error at first, because it just looks like so.

The problem is that the configure.ac in gct-6.2.1653033972/gsi_openssh/source is an old one. I just noticed that the configure and configure.ac in there only support up to 3.0.X.

Now I understand the problem. I didn't notice that issue as the OP quoted from current code state - where it looks and is OK IIUC - but used the last release tarball when trying to build the package on AUR, which is pre 2022-05-24.

Also the current draft release still points to that version of Jun 8, 2022. The 301 support dates back to Feb 21 (see f60262d)

Yes, I haven't yet updated the draft release since copying the content from the last release.

fscheiner commented 9 months ago

@ickc: This issue will hence be solved with the next GCT release that will materialize before end of this year.

ickc commented 9 months ago

Thanks all. I guess it should be closed now.

fscheiner commented 9 months ago

Oh, we usually keep issues open until there's a release that fixes them.

ickc commented 9 months ago

Ok, sure. Thanks again! Sorry for not having time to look into it again and providing more details, but you all figured it out already.