search

gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
588 stars 173 forks source link

Add dividers into wallet for big numbers #1040

Open nathanielcwm opened 6 years ago

nathanielcwm commented 6 years ago

i took this from here:

ghost commented 6 years ago

Bitcoin has done that already, so we have a good startingpoint https://github.com/bitcoin/bitcoin/pull/4167

tomasbrod commented 6 years ago

I suggest space as a country-neutral divider.

G-UK commented 6 years ago

https://www.bipm.org/utils/en/pdf/Resol22CGPM-EN.pdf Resolution 10 "reaffirms that “Numbers may be divided in groups of three in order to facilitate reading; neither dots nor commas are ever inserted in the spaces between groups”, as stated in Resolution 7 of the 9th CGPM, 1948."

denravonska commented 6 years ago

Bitcoin uses space as dividers. I tested a cherry pick but it looks a bit messy, doesn't it? screenshot from 2018-05-27 21-34-49

personthingman2 commented 6 years ago

It does look a little messy. But most users will only have 0 - 1 spaces before the decimal point.

Not many people have over a million coins.

Nethlek commented 6 years ago

still better than the current system imo, although instead of all these empty spaces on the transactions, it should either spell out the 0s or just move it closer to the GRC like it does now. i prefer the latter.

edit: maybe make the space dividers on the right optional or allow anything below X digits to be hidden and let users decide for themselves. like "what is the smallest unit you want displayed" with the options "grc cent, mgrc cent, µgrc cent (halfords)"

edit2: it should always round down though.

madmaxpayne commented 6 years ago

Why not to use comma to separate thousands? Or make that these fields will use number format from system settings?

Nethlek commented 6 years ago

some countries use commas and periods the other way around, spaces are the least confusing option universally speaking. maybe using system settings would be harder to implement than simply adding a few spaces. even if that isnt true, i'd still prefer a universal appearance.

ghost commented 6 years ago

bitcoin has reverted the thousands separators after decimal point.So only if you have >1000grc you will see the spaces https://github.com/bitcoin/bitcoin/pull/4867

tomasbrod commented 6 years ago

edit2: it should always round down though.

Why? >5 round up.

maybe make the space dividers on the right optional

IMhO spaces after decimal point are useless. At least for current coin price.