search

gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
585 stars 173 forks source link

Circular Dependencies #2160

Open barton2526 opened 3 years ago

barton2526 commented 3 years ago

From Linter:



A new circular dependency in the form of "chainparams -> protocol -> chainparams" appears to have been introduced.

A new circular dependency in the form of "checkpoints -> main -> checkpoints" appears to have been introduced.

A new circular dependency in the form of "consensus/merkle -> main -> consensus/merkle" appears to have been introduced.

A new circular dependency in the form of "gridcoin/beacon -> gridcoin/contract/contract -> gridcoin/beacon" appears to have been introduced.

A new circular dependency in the form of "gridcoin/beacon -> main -> gridcoin/beacon" appears to have been introduced.

A new circular dependency in the form of "gridcoin/claim -> main -> gridcoin/claim" appears to have been introduced.

A new circular dependency in the form of "gridcoin/contract/contract -> gridcoin/project -> gridcoin/contract/contract" appears to have been introduced.

A new circular dependency in the form of "gridcoin/contract/contract -> gridcoin/voting/registry -> gridcoin/contract/contract" appears to have been introduced.

A new circular dependency in the form of "gridcoin/contract/contract -> main -> gridcoin/contract/contract" appears to have been introduced.

A new circular dependency in the form of "gridcoin/gridcoin -> init -> gridcoin/gridcoin" appears to have been introduced.

A new circular dependency in the form of "gridcoin/project -> main -> gridcoin/project" appears to have been introduced.

A new circular dependency in the form of "gridcoin/quorum -> main -> gridcoin/quorum" appears to have been introduced.

A new circular dependency in the form of "gridcoin/scraper/fwd -> gridcoin/scraper/scraper_net -> gridcoin/scraper/fwd" appears to have been introduced.

A new circular dependency in the form of "gridcoin/scraper/scraper_net -> main -> gridcoin/scraper/scraper_net" appears to have been introduced.

A new circular dependency in the form of "gridcoin/staking/difficulty -> main -> gridcoin/staking/difficulty" appears to have been introduced.

A new circular dependency in the form of "gridcoin/staking/kernel -> main -> gridcoin/staking/kernel" appears to have been introduced.

A new circular dependency in the form of "gridcoin/staking/reward -> main -> gridcoin/staking/reward" appears to have been introduced.

A new circular dependency in the form of "gridcoin/superblock -> main -> gridcoin/superblock" appears to have been introduced.

A new circular dependency in the form of "gridcoin/tally -> main -> gridcoin/tally" appears to have been introduced.

A new circular dependency in the form of "init -> net -> init" appears to have been introduced.

A new circular dependency in the form of "init -> rpc/server -> init" appears to have been introduced.

A new circular dependency in the form of "init -> wallet/walletdb -> init" appears to have been introduced.

A new circular dependency in the form of "keystore -> script -> keystore" appears to have been introduced.

A new circular dependency in the form of "logging -> util/time -> logging" appears to have been introduced.

A new circular dependency in the form of "main -> policy/policy -> main" appears to have been introduced.

A new circular dependency in the form of "main -> script -> main" appears to have been introduced.

A new circular dependency in the form of "main -> validation -> main" appears to have been introduced.

A new circular dependency in the form of "net -> wallet/db -> net" appears to have been introduced.

A new circular dependency in the form of "netbase -> util -> netbase" appears to have been introduced.

A new circular dependency in the form of "qt/bantablemodel -> qt/clientmodel -> qt/bantablemodel" appears to have been introduced.

A new circular dependency in the form of "qt/clientmodel -> qt/peertablemodel -> qt/clientmodel" appears to have been introduced.

A new circular dependency in the form of "qt/researcher/researchermodel -> qt/researcher/researcherwizard -> qt/researcher/researchermodel" appears to have been introduced.

A new circular dependency in the form of "sync -> util -> sync" appears to have been introduced.

A new circular dependency in the form of "txdb -> txdb-leveldb -> txdb" appears to have been introduced.

A new circular dependency in the form of "txdb-leveldb -> validation -> txdb-leveldb" appears to have been introduced.

A new circular dependency in the form of "wallet/wallet -> wallet/walletdb -> wallet/wallet" appears to have been introduced.

A new circular dependency in the form of "chainparams -> consensus/merkle -> main -> chainparams" appears to have been introduced.

A new circular dependency in the form of "checkpoints -> main -> validation -> checkpoints" appears to have been introduced.

A new circular dependency in the form of "consensus/tx_verify -> main -> policy/policy -> consensus/tx_verify" appears to have been introduced.

A new circular dependency in the form of "gridcoin/beacon -> gridcoin/contract/contract -> gridcoin/researcher -> gridcoin/beacon" appears to have been introduced.

A new circular dependency in the form of "gridcoin/contract/contract -> gridcoin/researcher -> gridcoin/contract/message -> gridcoin/contract/contract" appears to have been introduced.

A new circular dependency in the form of "gridcoin/contract/contract -> gridcoin/tx_message -> primitives/transaction -> gridcoin/contract/contract" appears to have been introduced.

A new circular dependency in the form of "gridcoin/project -> main -> gridcoin/researcher -> gridcoin/project" appears to have been introduced.

A new circular dependency in the form of "gridcoin/quorum -> main -> gridcoin/researcher -> gridcoin/quorum" appears to have been introduced.

A new circular dependency in the form of "gridcoin/researcher -> gridcoin/tally -> main -> gridcoin/researcher" appears to have been introduced.

A new circular dependency in the form of "gridcoin/scraper/fwd -> gridcoin/scraper/scraper_net -> gridcoin/superblock -> gridcoin/scraper/fwd" appears to have been introduced.

A new circular dependency in the form of "gridcoin/scraper/fwd -> util -> ui_interface -> gridcoin/scraper/fwd" appears to have been introduced.

A new circular dependency in the form of "gridcoin/staking/kernel -> txdb -> txdb-leveldb -> gridcoin/staking/kernel" appears to have been introduced.

A new circular dependency in the form of "gridcoin/staking/kernel -> main -> validation -> gridcoin/staking/kernel" appears to have been introduced.

A new circular dependency in the form of "init -> wallet/wallet -> main -> init" appears to have been introduced.

A new circular dependency in the form of "init -> wallet/wallet -> rpc/client -> init" appears to have been introduced.

A new circular dependency in the form of "init -> wallet/wallet -> rpc/protocol -> init" appears to have been introduced.

A new circular dependency in the form of "main -> txdb -> txdb-leveldb -> main" appears to have been introduced.

A new circular dependency in the form of "main -> net -> wallet/db -> main" appears to have been introduced.

A new circular dependency in the form of "main -> validation -> wallet/wallet -> main" appears to have been introduced.

A new circular dependency in the form of "sync -> util -> util/time -> sync" appears to have been introduced.

A new circular dependency in the form of "alert -> chainparams -> consensus/merkle -> main -> alert" appears to have been introduced.

A new circular dependency in the form of "consensus/tx_verify -> main -> validation -> wallet/wallet -> consensus/tx_verify" appears to have been introduced.

A new circular dependency in the form of "gridcoin/staking/kernel -> main -> validation -> wallet/wallet -> gridcoin/staking/kernel" appears to have been introduced.

A new circular dependency in the form of "gridcoin/support/block_finder -> main -> validation -> wallet/wallet -> gridcoin/support/block_finder" appears to have been introduced.

A new circular dependency in the form of "txdb -> txdb-leveldb -> validation -> wallet/wallet -> txdb" appears to have been introduced.

A new circular dependency in the form of "gridcoin/accrual/newbie -> gridcoin/beacon -> gridcoin/contract/contract -> gridcoin/researcher -> gridcoin/tally -> gridcoin/accrual/newbie" appears to have been introduced.

A new circular dependency in the form of "gridcoin/accrual/snapshot -> gridcoin/beacon -> gridcoin/contract/contract -> gridcoin/researcher -> gridcoin/tally -> gridcoin/accrual/snapshot" appears to have been introduced.

^---- failure generated from test/lint/lint-circular-dependencies.sh```
jamescowens commented 3 years ago

I will let @cyrossignol take a look at this. I checked a few and I don't see them.

jamescowens commented 2 years ago

Pushing this off to Kermit's Mom where we have more tjme to analyze and fix. I think @denravonska was going to take a crack at it, but I don't know what happened to that.