search

gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
585 stars 173 forks source link

Properly include Boost Array header #2730

Closed theMarix closed 6 months ago

theMarix commented 6 months ago

With Boost 1.84 the Boost Array header no longer seems to be implicitly included by other Boost headers we are using. Thus, our usages of boost::array run into an incomplete type.

This includes boost/array.hpp everywhere we explicitly use boost::array to ensure we do not depend on implicit includes.

theMarix commented 6 months ago

Not sure what to do about that lint error. It fails because I supposedly added a dependency on Boost Arrray. However, that dependency was already used, I only seem to have to have made it explicit by adding the proper include.

jamescowens commented 6 months ago

Ah. There is something we have to change in the linter config files to fix this. I will take a look. :)

jamescowens commented 6 months ago

Hey @theMarix. I think if you add this dependency to Gridcoin-Research/test/lint/lint-includes.sh under the section EXPECTED_BOOST_INCLUDES it should clear the lint error.

theMarix commented 6 months ago

Hey @theMarix. I think if you add this dependency to Gridcoin-Research/test/lint/lint-includes.sh under the section EXPECTED_BOOST_INCLUDES it should clear the lint error.

I'll give it a try. Thanks!

theMarix commented 6 months ago

Hey @theMarix. I think if you add this dependency to Gridcoin-Research/test/lint/lint-includes.sh under the section EXPECTED_BOOST_INCLUDES it should clear the lint error.

I'll give it a try. Thanks!

@jamescowens , thanks for the hint. Tests are now passing.