search

gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
585 stars 173 forks source link

build: CMake: Initial Windows support (MSYS2) #2733

Closed CyberTailor closed 3 months ago

CyberTailor commented 5 months ago

This PR is a follow-up to #2676. The following changes make it possible to build Gridcoin with CMake in Windows.

It also adds the Hunter dependency manager for systems without package management abilities.

TODO for next pull requests:

jamescowens commented 5 months ago

I just merged https://github.com/gridcoin-community/Gridcoin-Research/pull/2734. You probably need to rebase this on the development branch again.

div72 commented 5 months ago

@CyberTailor Why hunter, instead of (for example) conan?

P.S. MacOS CI failure is unrelated, seems like a GH issue.

CyberTailor commented 5 months ago

Why hunter, instead of (for example) conan?

I'm not familiar with Conan and don't know any projects that use it with CMake.

CyberTailor commented 5 months ago

(sorry for confusion, i've mistook browser tabs)

jamescowens commented 4 months ago

@CyberTailor can we get this into Miss Piggy or should I push to Natasha?

CyberTailor commented 4 months ago

I think yes. It'd be hard to continue without feedback

jamescowens commented 4 months ago

@div72?

div72 commented 4 months ago

I did take a peek at this PR, nothing popped out to me but I haven't used CMake before and I'm not a Windows user so I don't really think I'm qualified to give a proper review. There does seem to be something weird on how defines are processed (also on MacOS) but it seems to compile and run ok.

Since automake is currently our sanctioned build system, it shouldn't matter if this lands in Miss Piggy or Natasha imo as long as there are no code changes.

jamescowens commented 3 months ago

I am not qualified to review it either. If it seems to compile and run ok, lets go ahead and merge it.