gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
585 stars 173 forks source link

Setban causes segfault on malformed IP #2750

Closed CallMeFoxie closed 3 months ago

CallMeFoxie commented 4 months ago

Bug Report

Current behavior gridcoinresearchd crashes when given a wrong IP on setban command

Expected behavior ban a remote

Steps to reproduce:

for peer in $(gridcoinresearchd getpeerinfo | jq '.[] | select(.subver=="/Halford:5.4.5/") | .addr' -r); do gridcoinresearchd setban $peer add 3600; done

the output is in format ip:port of the remotes, not just pure IPs, however this causes a segfault

63613064.639190] gridcoinresearc[12613]: segfault at 0 ip 000055e6fc7209b8 sp 00007feef77fc8f0 error 4 in gridcoinresearchd[55e6fc2e9000+648000]

however stripping the port part works fine

for peer in $(gridcoinresearchd getpeerinfo | jq '.[] | select(.subver=="/Halford:5.4.5/") | .addr' -r); do gridcoinresearchd setban $(echo $peer | cut -d':' -f1) add 3600; done

Gridcoin version v.5.4.6.0

Machine specs