gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
585 stars 172 forks source link

gui: Consolidation Wizard doesn't work when accessed from Inputs window #2765

Closed Frigyes06 closed 1 month ago

Frigyes06 commented 4 months ago

Bug Report

Current behavior When viewing the Inputs window "Coin Control" in the send tab, if you click "Consolidate", the resulting window doesn't let you select a destination address, nor does it have any button other than "OK"

Expected behavior The consolidate button opens the consolidation wizard with full functionality.

Steps to reproduce:

Screenshots

Non-functional consolidation wizard accessed from Inputs: image

Functional Consolidation wizard accessed directly from send tab: image

Gridcoin version

v5.4.8.0, downloaded from the AUR

Machine specs

Extra information

Frigyes06 commented 4 months ago

Haha image clipboard being goofy again, lemme retry that

barton2526 commented 4 months ago

I am seeing this on Windows 10 as well

jamescowens commented 4 months ago

Hmm... This is actually working as originally coded. The consolidate button within the inputs selection (coin control dialog) operates differently than the full wizard. If you hover over the consolidate button within the coin control dialog, it has a tool tip that explains how it works. You select inputs from the coin control page (direct or using the filter), and then when you press the consolidate button you select the destination address. This returns you to the coin control dialog with the destination set. There will be a green "Ready to consolidate" message. When you press ok to the coin control dialog, you will be returned to the send dialog with a transaction pre-filled in ready to go.

I agree this is probably not ideal in the sense it is too implicit, and quite frankly duplicates in a less elegant way the functionality of the wizard button.