Large magnitude values in explainmagnitude

gridcoin-community / Gridcoin-Research

Gridcoin-Research

MIT License

585 stars 172 forks source link

Large magnitude values in explainmagnitude #540

Closed Erkan-Yilmaz closed 6 years ago

Erkan-Yilmaz commented 7 years ago

I noticed such a case also 2 days ago:

highmag

"6" : "NN Host Version: 423, NeuralHash: d41d8cd98f00b204e9800998ecf8427e, SignatureCPID: fdb8dfc010b5e72295e4abf530876ed9, Time: 24/08/2017 02:08:20", "7" : "Total RAC: 36646.67", "8" : "Total Mag: 17552549146.19"

Such a high magnitude can never be possible:

why is it not thrown away or disregarded so values from a correct hash are shown instead ?
- e.g. Gridcoin has a mag limit somewhere already applied: 20k mag for a single CPID
there should be a simple check, so such things don't interfere with the SB quorum period (e.g. a malicious person could try that?), or at least don't land in my Gridcoin client

The above SignatureCPID is from a user with name:

from fediverse:

"last superblock: #1001595, 23h 53 mins ago (2017-08-23 06:39:12)"

version: 3.6.0.1, on linux

Erkan-Yilmaz commented 7 years ago

lines 2-5 from above pic, in formatted view:

single_mags

WhiteCat6142 commented 6 years ago

I'm in a similar situation.Report follows

v3.6.3.0 on linux gridcoinresearchd execute explainmagnitude2 true [ { "Command" : "explainmagnitude2" }, { "1" : "CPID,Project,RAC,Project_Total_RAC,Project_Avg_RAC,Project Mag,Cumulative RAC,Cumulative Mag,Errors", "18" : "NN Host Version: 424, NeuralHash: d41d8cd98f00b204e9800998ecf8427e, SignatureCPID: INVESTOR, Time: 12/16/2017 9:15:25 PM", "19" : "Total RAC: 7290", "20" : "Total Mag: 3352059176.32" } ]

iFoggz commented 6 years ago

the d41d hash means empty neural contract. so i'm not surprised that high total mag thou it should try to display any data if the neural hash is as such. might even possible the neural nodes could be sending a reply while in middle of a sync? more stuff to look at

tomasbrod commented 6 years ago

Flash news: Do not trust the output of explainmagnitude. The data it displays are obtained via unrevised protocol from arbitrary node around the network. The data is thankfully not used anywhere else. It was probably a debugging command left behind.

iFoggz commented 6 years ago

close @denravonska i dont see a big issue here. some of my explainmagnitude code addresses some of these issues