search

gridcoin-community / Gridcoin-Research

Gridcoin-Research
MIT License
588 stars 173 forks source link

Running help command in debug outputs 'stopping' to debug log #878

Closed ShmoogleOsukami closed 6 years ago

ShmoogleOsukami commented 6 years ago

Pretty self explanatory, Not sure why it outputs this, it's a little confusing. Thought I'd write this just for the record.

This is on windows client in debug window in case it behave differently in Linux clients.

RoboticMind commented 6 years ago

I was able to reproduce this. Here's what it said in the logs: 01/27/18 20:30:28 Stopping...

tomasbrod commented 6 years ago

The help command is implemented by running each possible command with fHelp flag set and taking first line of the exception text that is thrown.

iFoggz commented 6 years ago

Stopping... is printf to log before the throw of the help reply. it doesn't stop anything but should be moved i'll do as such

RoboticMind commented 6 years ago

Can we close this @denravonska

iFoggz commented 6 years ago

Yes close this as my pr previously accepted moves the print to log message to avoid the confusion

On Sat, Feb 17, 2018, 7:39 AM RoboticMind, notifications@github.com wrote:

Can we close this @denravonska https://github.com/denravonska

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gridcoin/Gridcoin-Research/issues/878#issuecomment-366449279, or mute the thread https://github.com/notifications/unsubscribe-auth/AMrVQKnLEhmeYfhgpMtVczoOXvUM3PpFks5tVvLNgaJpZM4RvXym .