gridcoin-community / Gridcoin-Tasks

Gridcoin community tasks repository
https://gridcoin.us
MIT License
24 stars 5 forks source link

Improve upon client translations! (23 unsupported languages!) #116

Closed skcin closed 4 years ago

skcin commented 6 years ago

Issue by grctest Sunday Apr 16, 2017 at 17:21 GMT Originally opened as https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues/111


I believe that getting the Gridcoin client translated to Chinese (Cantonese/Mandarin) is a high priority - getting added to a Chinese exchange won't happen without language support.

As well as Chinese there are 23 other languages with incomplete translation entries, this is not ok considering our community is distributed around the world. The unsupported languages show '???' throughout the client despite being an available option in the language drop-down menu.

Until we have full translations, I believe it would be far more professional to simply not display unsupported languages within the drop-down menu

Can we get some volunteers to provide translations? It would be major kudos within the community! In the mean time we should consider placing bounties on full translations and look towards similar cryptocurrencies for quick translation inheritance (gives us a head start).

Affected files: Gridcoin:ar ; Blackcoin:ar Gridcoin:be_BY ; Blackcoin:be_BY Gridcoin:bg ; Blackcoin:bg Gridcoin:el_GR ; Blackcoin:el_GR Gridcoin:fa ; Blackcoin:fa Gridcoin:fa_IR ; Blackcoin:fa_IR Gridcoin:he ; Blackcoin:he Gridcoin:hi_IN ; Blackcoin:hi_IN Gridcoin:ja ; Blackcoin:ja Gridcoin:ka ; Blackcoin:ka Gridcoin:kk_KZ ; Blackcoin:kk_KZ Gridcoin:ko_KR ; Blackcoin:ko_KR Gridcoin:ky ; Blackcoin:ky Gridcoin:ro_RO ; Blackcoin:ro_RO Gridcoin:sah ; Blackcoin:sah Gridcoin:sr ; Blackcoin:sr Gridcoin:th_TH ; Blackcoin:th_TH Gridcoin:tr ; Blackcoin:tr Gridcoin:uk ; Blackcoin:uk Gridcoin:ur ; Blackcoin:PK ; Blackcoin:ur ; Blackcoin:PK Gridcoin:vi ; Blackcoin:vi Gridcoin:zh_CN ; Blackcoin:zh_CN Gridcoin:zh_TW ; Blackcoin:zh_TW Gridcoin:fa ; Blackcoin:fa

Reference: (includes non-affected translations) image

skcin commented 6 years ago

Comment by PsiPhiTheta Sunday Apr 16, 2017 at 20:40 GMT


Guys I am willing to do the entire french translation. Can someone send me a list of all the words to translate for Gridcoin? (I'll have a look at the Blackcoin translation, review and alter it where necessary)

It looks like French has not been linked in anyway - has it already been done?

skcin commented 6 years ago

Comment by grctest Sunday Apr 16, 2017 at 20:44 GMT


Guys I am willing to do the entire french translation. Can someone send me a list of all the words to translate for Gridcoin? (I'll have a look at the Blackcoin translation, review and alter it where necessary)

It looks like French has not been linked in anyway - has it already been done?

https://github.com/gridcoin/Gridcoin-Research/blob/master/src/qt/locale/bitcoin_fr.ts https://github.com/gridcoin/Gridcoin-Research/blob/master/src/qt/locale/bitcoin_fr_CA.ts

It would appear that French has already been translated, you could always perform a review of the translations in an effort to improve existing translations?

Thanks 👍

skcin commented 6 years ago

Comment by tomasbrod Sunday Apr 16, 2017 at 21:02 GMT


I am here for the sk_SK translation. Even if only 5 people will actually use it, haha. It is present, but broken. What encoding is being used, Unicode UTF-8? Looks like all ť got replaced by ?.

skcin commented 6 years ago

Comment by PsiPhiTheta Sunday Apr 16, 2017 at 21:19 GMT


It would appear that French has already been translated, you could always perform a review of the translations in an effort to improve existing translations?

Done.

skcin commented 6 years ago

Comment by grctest Sunday Apr 16, 2017 at 21:29 GMT


I am here for the sk_SK translation. Even if only 5 people will actually use it, haha. It is present, but broken. What encoding is being used, Unicode UTF-8? Looks like all ť got replaced by ?.

I believe something similar occurred for the Hungarian translation (fixed recently by a community member), if you're able to substitute the '?' character with the appropriate character that would be excellent.

If there are multiple '???' characters in a row that means the translation wasn't supplied in the first place (not the case for sk_SK).

Something else I've spotted is that throughout the translations we are missing copyright credits to blackcoin for their work done after peercoin (and before gridcoin).

skcin commented 6 years ago

Comment by JovanDj Sunday Apr 16, 2017 at 22:32 GMT


I will do the sr translation. Do I fork the file then push the translated file?

skcin commented 6 years ago

Comment by grctest Monday Apr 17, 2017 at 00:43 GMT


I will do the sr translation. Do I fork the file then push the translated file?

Yeah, create a fork of the Gridcoin-Research repo, change the files then submit a pull request. Thanks for helping 👍

skcin commented 6 years ago

Comment by grctest Monday Apr 17, 2017 at 02:17 GMT


<translation type="unfinished"></translation> <translation type="unfinished"/>

The above are also used instead of "???" To identify a lack of translations.

skcin commented 6 years ago

Comment by denravonska Monday Apr 17, 2017 at 08:41 GMT


Everyone translating should use Qt Linguist to make it easier to translate and to ensure that nothing is missed. I don't think it's available as a standalone download, so you'd have to install Qt Creator. Also, use the language files from the development branch, which just got rescanned.

Some other notes is to ignore translations which contain stylesheets, for example:

<source>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-size:20px; font-weight:600; color:#000000;&quot;&gt;Wallet&lt;/span&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</source>

These come from the dialog forms files which are currently being stripped of their CSS. Tranlations done to those strings will likely have to be retranslated later. Translating lines with simple HTML tags is fine but stay away from the stylesheet ones.

I can do the Swedish translation.

skcin commented 6 years ago

Comment by tomasbrod Wednesday Apr 19, 2017 at 10:21 GMT


The problem with Qt Linguist is that it has all translations marked as done. Even the broken ones and I did not find how to mark all non-done. So it does not really help.

skcin commented 6 years ago

Comment by denravonska Wednesday Apr 19, 2017 at 10:30 GMT


@tomasbrod Which language do you mean?

Edit: Ah, sk. Now I see the problem.

skcin commented 6 years ago

Comment by HuguesDohmen Wednesday Apr 19, 2017 at 19:08 GMT


If translations in duch need to be done, I will give it a shot.

skcin commented 6 years ago

Comment by tomasbrod Wednesday Apr 19, 2017 at 19:25 GMT


@denravonska The Slovak language. Additionally there are multiple unused strings and, what is worse, a lot of duplicate strings in the locale files. https://github.com/tomasbrod/Gridcoin-Research/tree/locale/sk

skcin commented 6 years ago

Comment by denravonska Friday Apr 21, 2017 at 04:04 GMT


@tomasbrod I assumed duplicate translations got merged by Qt Linguist but I might be wrong.

I've left the vanished leftover translations in the files for this translation run under the assumption that they were used by the tool to provide translation suggestions for new strings.

@HuguesDohmen I'm pretty sure they do :)

skcin commented 6 years ago

Comment by denravonska Saturday Apr 22, 2017 at 16:14 GMT


I have added 26 translations which were in the source tree but not in the final build:

+        <file alias="af_ZA">locale/bitcoin_af_ZA.qm</file>
+        <file alias="be_BY">locale/bitcoin_be_BY.qm</file>
+        <file alias="bg">locale/bitcoin_bg.qm</file>
+        <file alias="bs">locale/bitcoin_bs.qm</file>
+        <file alias="ca">locale/bitcoin_ca.qm</file>
+        <file alias="ca@valencia">locale/bitcoin_ca@valencia.qm</file>
+        <file alias="cy">locale/bitcoin_cy.qm</file>
+        <file alias="es_MX">locale/bitcoin_es_MX.qm</file>
+        <file alias="es_UY">locale/bitcoin_es_UY.qm</file>
+        <file alias="et">locale/bitcoin_et.qm</file>
+        <file alias="eu_ES">locale/bitcoin_eu_ES.qm</file>
+        <file alias="fa_IR">locale/bitcoin_fa_IR.qm</file>
+        <file alias="hi_IN">locale/bitcoin_hi_IN.qm</file>
+        <file alias="id_ID">locale/bitcoin_id_ID.qm</file>
+        <file alias="kk_KZ">locale/bitcoin_kk_KZ.qm</file>
+        <file alias="ky">locale/bitcoin_ky.qm</file>
+        <file alias="la">locale/bitcoin_la.qm</file>
+        <file alias="lv_LV">locale/bitcoin_lv_LV.qm</file>
+        <file alias="ms_MY">locale/bitcoin_ms_MY.qm</file>
+        <file alias="sah">locale/bitcoin_sah.qm</file>
+        <file alias="sq">locale/bitcoin_sq.qm</file>
+        <file alias="sr">locale/bitcoin_sr.qm</file>
+        <file alias="th_TH">locale/bitcoin_th_TH.qm</file>
+        <file alias="ur_PK">locale/bitcoin_ur_PK.qm</file>
+        <file alias="vi_VN">locale/bitcoin_vi_VN.qm</file>
+        <file alias="vi">locale/bitcoin_vi.qm</file>
skcin commented 6 years ago

Comment by denravonska Monday May 29, 2017 at 12:04 GMT


Standalone Qt Linguist installers are available at https://github.com/lelegard/qtlinguist-installers/releases. This is probably the easiest way for translators to help.

skcin commented 6 years ago

Comment by grctest Tuesday May 30, 2017 at 18:42 GMT


Looks like there's a larger amount of translations available within the official bitcoin repo: https://github.com/bitcoin/bitcoin/tree/master/src/qt/locale

It appears to use a different format, however we could pick and choose..

skcin commented 6 years ago

Comment by mrip0001 Thursday Jun 29, 2017 at 17:47 GMT


I will try the Chinese中文 translation

skcin commented 6 years ago

Comment by mrip0001 Friday Jun 30, 2017 at 17:23 GMT


https://github.com/gridcoin/Gridcoin-Research/pull/404 I finished the Chinese中文 translation of Gridcoin格雷德币