[CLOSED] get additional github administration rights for bugtracker

gridcoin-community / Gridcoin-Tasks

Gridcoin community tasks repository

https://gridcoin.us

MIT License

24 stars 5 forks source link

[CLOSED] get additional github administration rights for bugtracker #44

Closed skcin closed 6 years ago

skcin commented 6 years ago

Issue by Erkan-Yilmaz Sunday Jan 22, 2017 at 02:16 GMT Originally opened as https://github.com/Erkan-Yilmaz/Gridcoin-tasks/issues/41

so easy pull requests (typos) could be merged into the code
more difficult PRs should still require a certain procedure:
- tested on these OS (windows, linux, ...) ?
- done these, agreed on, test cases ?
- and also test cases which are relevant for the changed code parts ?
- unit tests were added ?
- ...
who should get the additional flag ?

see @denravonska 's comment here

assigning to @grctest

skcin commented 6 years ago

Comment by grctest Sunday Jan 22, 2017 at 15:02 GMT

It should be assigned to @gridcoin because he's the only one who can change this.

skcin commented 6 years ago

Comment by denravonska Sunday Jan 22, 2017 at 17:18 GMT

Just to reiterate what I said/wanted to say at the hangout.

Push privileges require a good bit of trust, especially for these kind of applications. As an alternative we could have a couple of trusted developers who can take the first code reviews. When the PRs have passed those developers Rob can have a final look and do the merge. Eventually some of those developers could have gained enough trust to get push privileges but for now it's a good middle ground.

I also agree about using a development branch for continuous development and PRs instead of pushing everything into master.

skcin commented 6 years ago

Comment by grctest Friday Jan 27, 2017 at 23:38 GMT

https://cryptocointalk.com/topic/52186-gridcoin-community-development-process-idea/#entry232500

We've created a gridcoin-community organization, where we can explore improved github workflow.

What tools should we directly integrate into the org or repos?

skcin commented 6 years ago

Comment by grctest Monday Jan 30, 2017 at 14:44 GMT

Closed because we've created the gridcoin-community repo to gain these permissions. I'll create an additional issue regarding the integration of tools.