search

griddb / griddb_ycsb

GridDB connector for YCSB
Apache License 2.0
1 stars 1 forks source link

Inclusion in YCSB project? #1

Open busbey opened 6 years ago

busbey commented 6 years ago

Hi folks!

I'm getting set to do some cleanup on the YCSB project focused on getting old PRs that needed a bit of polish merged.

There's one for adding GridDB support:

https://github.com/brianfrankcooper/YCSB/pull/1018

There's an open question on wether y'all would prefer to maintain your client binding as an independent project or have it merged into YCSB. Either way is fine by me, do y'all have a preference?

knonomura commented 6 years ago

Thank you very much for the information.

Sorry we weren't aware of the PR for adding the GridDB support. We'd be happy to merge the GridDB connector to YCSB project.

Thanks.

busbey commented 6 years ago

that's great! I imagine that at this point the existing PR is a bit stale. would y'all like to bring the current one up to speed with this repository? Would you prefer to just make a new PR?

knonomura commented 6 years ago

If possible, we'd like to proceed with the former.

knonomura commented 6 years ago

I have an additional information.

This connector has a dependency with GridDB Java Client (gridstore.jar), but it isn't registered on Maven Central Repository yet.

So, for the build environment, I am thinking of the following approach:

Step 1. Enable build from YCSB binary with local Java Client (jar) <-- the current Step 2. Enable build from YCSB source code with local Java Client (jar) Step 3. Enable build from YCSB source code with Java Client on Maven Central Repository

I will make another PR for Step 2 around next week, but Step 3 may take some time.

knonomura commented 5 years ago

Step 1. Enable build from YCSB binary with local Java Client (jar) Step 2. Enable build from YCSB source code with local Java Client (jar) <-- the current Step 3. Enable build from YCSB source code with Java Client on Maven Central Repository

I am currently undergoing Step 3.

busbey commented 5 years ago

👍

knonomura commented 5 years ago

Just now I finished Step 3.

Step 1. Enable build from YCSB binary with local Java Client (jar) Step 2. Enable build from YCSB source code with local Java Client (jar) Step 3. Enable build from YCSB source code with Java Client on Maven Central Repository <-- the current

Could you please check my PR ? brianfrankcooper/YCSB#1258