griddynamics / mpl

[IT-36925] Jenkins Shared Modular Pipeline Library
https://blog.griddynamics.com/developing-a-modular-pipeline-library-to-improve-devops-collaboration/
Apache License 2.0
158 stars 97 forks source link

Jenkins Plugin #48

Open ctran opened 4 years ago

ctran commented 4 years ago

Have you ever thought about converting mpl into a Jenkins plugin?

sparshev commented 4 years ago

Hi @ctran,

Yeah, of course - but this conversion have a couple of issues:

But when the functionality will be stabilized, probably those issues will be gone and we can simplify some mechanisms by converting the MPL core into plugin - and anyone would be able to use shared library or plugin on their choice.

Thank you

rolaca11 commented 2 years ago

Do you think the functionalities have stabilized yet?

With the change in library name format (#96) it would've been great if we were notified about the incompatibility a change like this could cause.

sparshev commented 2 years ago

Hi @rolaca11 , I think the functionality is quite stable and I agree the notification mechanism right now is far from ideal.

Overall developing of the MPL plugin (or addition to the common jenkins steps) is a good idea and could help with some typical tasks. But the shared library approach still looks better for me in comparison with the plugin approach and I can't spend my time on this development anytime soon.

To address the issue with notifications I can actually make releases of the MPL on github page - do you think that will help?

rolaca11 commented 2 years ago

What I thought was that the plugin itself could automatically configure the shared library for MPL. Some options should be overridable, like the shared lib name, or the revision tag. This shouldn't be a big task, if I have some time I can try and create a POC.

Sergei Parshev @.***> ezt írta (időpont: 2022. febr. 24., Cs, 2:50):

Hi @rolaca11 https://github.com/rolaca11 , I think the functionality is quite stable and I agree the notification mechanism right now is far from ideal.

Overall developing of the MPL plugin (or addition to the common jenkins steps) is a good idea and could help with some typical tasks. But the shared library approach still looks better for me in comparison with the plugin approach and I can't spend my time on this development anytime soon.

To address the issue with notifications I can actually make releases of the MPL on github page - do you think that will help?

— Reply to this email directly, view it on GitHub https://github.com/griddynamics/mpl/issues/48#issuecomment-1049413692, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXAQAV3JTXDQM666I6Q6MLU4WFHNANCNFSM4JILNRFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

sparshev commented 2 years ago

You mean like the existing jenkins CaC plugin https://plugins.jenkins.io/configuration-as-code/? Don't think the configuration of MPL should be automated in other way, because organizations most likely will have a fork of the MPL.

rolaca11 commented 2 years ago

Yes, something like this

Sergei Parshev @.***> ezt írta (időpont: 2022. febr. 24., Cs, 18:44):

You mean like the existing jenkins CaC plugin https://plugins.jenkins.io/configuration-as-code/? Don't think the configuration of MPL should be automated in other way, because organizations most likely will have a fork of the MPL.

— Reply to this email directly, view it on GitHub https://github.com/griddynamics/mpl/issues/48#issuecomment-1050102566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXAQAX5675D7JLUHEXDQDTU4ZVANANCNFSM4JILNRFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>