search

griddynamics / mpl

[IT-36925] Jenkins Shared Modular Pipeline Library
https://blog.griddynamics.com/developing-a-modular-pipeline-library-to-improve-devops-collaboration/
Apache License 2.0
156 stars 97 forks source link

Remove example module path #61

Closed marcelaraujo closed 4 years ago

marcelaraujo commented 4 years ago

Hi, is it possible to remove this default path and add it into MPLPipeline using MPLModulesPath?

https://github.com/griddynamics/mpl/blob/4ca95b9d157c39ebaea063691bb247d390846aff/src/com/griddynamics/devops/mpl/MPLManager.groovy#L50

sparshev commented 4 years ago

Hi @marcelaraujo

Need to think about it - probably it's not a good thing, that this path is set by default without a way to remove it, but adding new paths right now is located in MPLInit for the shared libraries. So let me check the possible ways.

marcelaraujo commented 4 years ago

I think you could use MPLModulesPath inside MPLPipeline.groovy and fix ours both needs.

sparshev commented 4 years ago

@marcelaraujo , there is multiple ways - but when you making some changes that breaking the backward-compatibility - you need to be very cautious.

Could you please describe - what the particular issue you have with this default path?

sparshev commented 4 years ago

@marcelaraujo - I see no updates in this issue, could you please check my last question?

sparshev commented 4 years ago

No answer for 2w, closing the issue.