gridhead / sanctuary-zero

A command-line bound implementation of secure synchronous lightweight chatroom with zero logging and total transience built using WebSockets, Fernet Cryptography, Asyncio and Prompt Toolkit
GNU General Public License v3.0
57 stars 34 forks source link

Chatroom with the same name should be allowed to be created #37

Open gridhead opened 3 years ago

gridhead commented 3 years ago

Check with the server and disallow chatroom creation if a chatroom with the same name already exists.

vinmay commented 3 years ago

Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo?

adhyay2000 commented 3 years ago

Can I work on this?

gridhead commented 3 years ago

Hey @t0xic0der, I see the issue says 'Chatroom with the same name should be allowed to be created' but ion the comment I see we want to disallow creation if we find chatrooms with same name. Is this a typo?

Two chatrooms with the same name lose their uniqueness so if a chatroom with a name exists, another chatroom with the same name should not be allowed to be created. Do you want this issue to be assigned to you?

gridhead commented 3 years ago

You have been assigned 2 issues from this repository as of now @adhyay2000 and @vinmay has been assigned 1 issue. I would suggest completing them first before moving onto this one.

Luv8436 commented 3 years ago

Hii @t0xic0der please assign this issue to me. I am intersted in working this.

gridhead commented 3 years ago

Cool. I am assigning this issue to you. @Luv8436

Feel free to leave a star at the repository if you find it useful.

gridhead commented 3 years ago

@Luv8436 did you make any progress on this?

Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @Vivek-blip

thevivekmnair commented 3 years ago

@Luv8436 did you make any progress on this?

Should @Luv8436 not respond or expresses disinterest, anyone up for it? @nat236919 @Vivek-blip

Yes i'm interested in solving this issue

adhyay2000 commented 3 years ago

Hi @Vivek-blip, you can see the PR opened by me. It already contains the code for generating the chatroom name at server side, you can maintain a set there to ensure just unique names are generated. It will solve the issue i guess. What do you say?