gridlab-d / gridlab-d

Source Code for GridLAB-D
Other
155 stars 110 forks source link

ev_charger_det randomization will result in perpetually shifting times #1035

Open ftuffner opened 7 years ago

ftuffner commented 7 years ago

The ev_charger_det object tracks location/operation transitions by adding a duration to the current time. If the variation_mean property (and associated variation_std_dev) are used, it can result in a perpetually accumulating offset. As such, the whole schedule will be offset more and more each day. i.e., offset1 is applied day 1, but day 2 is now offset1+offset2, and so on.

Could just remove the variability portion. Th ev_charger_det object may just need updating/rewriting, since it isn't very flexible right now.

Jacobhansens commented 7 years ago

If any work is done to correct this I suggest we also add in checks to ensure mismatch between mileage_classification and travel_distance is properly handled. Currently, if travel_distance is greater than mileage_classification no warming is displayed and the simulation continues as normal. The fix should be very simple as checks already exist to ensure that the SOC is always between 0-100%.