gridlab-d / gridlab-d

Source Code for GridLAB-D
Other
157 stars 109 forks source link

#630 #if tests always expand the first parameter even when no $ is used, #630

Open nikhilgupta10 opened 8 years ago

nikhilgupta10 commented 8 years ago

This is a legacy of V1 macro processing but it is very inconsistent with parameter expansion in all other parts of the loader. We should consider changing this in V3 to require use of ${} in the expression when variable substitution is expected and make the comparison strictly lexical.

This would also require the use of variable to allow backward compatibility by default with a warning message that this will be deprecated in a future version.

,

nikhilgupta10 commented 8 years ago

nikhilgupta10 imported these comments from Sourceforge: dchassin: * status changed from new to accepted ,

dchassin: * status changed from accepted to assigned ,

dchassin: * status changed from assigned to accepted ,

dchassin: * owner changed from dchassin to andyfisher

Fixed in r4029. Also fixed bad routing of #print, #error and #warning output from loader.

,

dchassin: This appears not to be in trunk yet.,

dchassin: If this isn't going to be included until 4.0 (which is reasonable), then we should at least fix the problem where the macro doesn't parse variable name that have period in them. As a result it's impossible to test the GridLAB-D version number in the GLM file, which is very useful.,

afisher1: - Description has changed:

Diff:

jcfuller1: - Milestone: Version 3.0 RC 1 --> Version 4.0 RC1

jcfuller1: This just needs validating and merging back into TRUNK.,

dchassin: Warning: this is a serious change in very basic functionality. This will come with potentially numerous changes to validation code and user models. Documentation on this needs to rock-solid before it's called good.,

dchassin: - assigned_to: Andy Fisher --> David P. Chassin ,

dchassin: If this is done in trunk and nobody has complained yet, then we should close this ticket.,

jcfuller1 commented 7 years ago

Believe this has been fixed, but needs a validation test to complete.