search

gridonic / hapi

PHP Wrapper Library for the Harvest API
GNU General Public License v3.0
41 stars 21 forks source link

Fixed Range class not working with HarvestAPI::getProjectEntries #1

Closed asgpha closed 10 years ago

asgpha commented 10 years ago

Hi,

The range method "to" and "from" were returning null because the construct class was still using the old PHP 4 syntax. In PHP 5, the correct syntax is __construct.

Thanks for writing this library and appreciate all your hard work.

peschee commented 10 years ago

Hi @asgpha

Thanks for the pull request. There might be even more of those older PHP 4 syntax issues. Since, for now, there are no automated tests, we'll need to figure them out as we go, when people start using the methods that might have issues. I'll merge your request right away.

Regards Peter