search

gridonic / hapi

PHP Wrapper Library for the Harvest API
GNU General Public License v3.0
41 stars 21 forks source link

Add recursive XML generation to abstract Harvest model #27

Closed MartinPeverelli closed 8 years ago

MartinPeverelli commented 8 years ago

This allows usage of an un-documented feature of Harvest for DayEntry: external_ref, which contains an array of values.

dschenk commented 8 years ago

Hi @MartinPeverelli, thanks for the PR! Looks good to me. Just one minor nit-pick: Can you please add spaces between "if" and "else" and the curly braces on line numbers 157, 159 and 161?

MartinPeverelli commented 8 years ago

@dschenk done. please let me know if we need any other changes.

peschee commented 8 years ago

@dschenk Looks good to me. I guess we can merge this. /cc @jfierz