search

gridonic / hapi

PHP Wrapper Library for the Harvest API
GNU General Public License v3.0
41 stars 21 forks source link

Remove non-SSL option #6

Closed tjschuck closed 9 years ago

tjschuck commented 10 years ago

Harvest will soon be removing the ability to make non-SSL API requests.

All Harvest accounts now support SSL, so the option should be removed.

peschee commented 9 years ago

@tjschuck Would you care to make a PR?

tjschuck commented 9 years ago

I haven't written PHP in years and am not a user of this library -- I was just letting you know about a change in Harvest's API. A PR from me would be an irresponsible hack job -- I'd just update these lines to be only $http = "https://";.

I don't know if that's sufficient (probably not? looks like there's also a setSSL option which would then be ignored), or how to test it, so... someone else should probably make a better PR with more guarantee of quality.

Sorry!

peschee commented 9 years ago

No worries, thanks for letting us know anyway @tjschuck Much appreciated.

peschee commented 9 years ago

Added in #9

tjschuck commented 9 years ago

Thanks @peschee and @bjornpost! :heart: :heart: :heart_eyes_cat: :heart: